Only move properties with setters to XAML attributes#3701
Merged
siegfriedpammer merged 1 commit intoicsharpcode:masterfrom Mar 31, 2026
Merged
Only move properties with setters to XAML attributes#3701siegfriedpammer merged 1 commit intoicsharpcode:masterfrom
siegfriedpammer merged 1 commit intoicsharpcode:masterfrom
Conversation
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers:
#3689
Problem
The
AttributeRewritePasswould create assignments via attributes despite the property not having a setter.Solution
The problem was remedied by checking if the property has a setter.
I also cleaned up the code a little.
I did not add a test as the input code provided in the issue will not compile under .NET 1,0 which is the TFM of the BamlDecompiler test project. The provided input code does compile on .NET 8.