Closed
Conversation
Contributor
Author
|
Not sure why the build on github fails. Builds fine locally... Oh, goddamnit, forgot the makefile in my commit. Fucking hate myself sometimes. |
StrikerTheHedgefox
force-pushed
the
main
branch
from
5f37598 to
c51521d
Compare
sezero
reviewed
Oct 19, 2025
StrikerTheHedgefox
force-pushed
the
main
branch
from
c51521d to
3c13d3d
Compare
Owner
|
I couldn't coerce this PR to merge for whatever reason, so I manually pushed the patch in 4e13e76. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds POD support. Since PODs don't have much of a header to go off of for file detection, I check if the last char of the description is a null terminator, and check if the start is non-null. Here's hoping it's enough. If not, maybe a file extension check should be added?
Also, this only supports POD1. POD2 through 5 are for when I have the time/patience, or someone else is willing to assist.