fix formatting strings in zfcp_ping and zfcp_show #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use %lx format when printing WWPN data stored in uint64_t variables/members as we are building on 64-bit systems exclusively and uint64_t is "long unsigned int" there. Signed-off-by: Dan Horák <dan@danny.cz>
Typecast the temp dest_val variable to uint32_t to match the data in it before printing. Signed-off-by: Dan Horák <dan@danny.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint64_t, so update the formatting string tolxas we are building for 64-bit platforms. Another option would be to usePRIx64from `<inttypes.h>.d_idmember isuint32_t, so rather typecast the local variable to it and keep thexformatter.