Skip to content

[patch] Fix core tests pipeline failure#2300

Open
unnati-solanki-git wants to merge 3 commits into
masterfrom
fixcoretests
Open

[patch] Fix core tests pipeline failure#2300
unnati-solanki-git wants to merge 3 commits into
masterfrom
fixcoretests

Conversation

@unnati-solanki-git
Copy link
Copy Markdown
Contributor

@unnati-solanki-git unnati-solanki-git commented May 21, 2026 •
edited
Loading

@unnati-solanki-git unnati-solanki-git marked this pull request as ready for review May 21, 2026 15:46
@unnati-solanki-git unnati-solanki-git requested a review from a team as a code owner May 21, 2026 15:46
terc1997
terc1997 reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@terc1997 terc1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Quick question, how does the dashboard behave in case of onError: continue ? Does it log everything ? If so, I think we should add the onError: continue in all FVT tests to not block the whole suite test.

@unnati-solanki-git
Copy link
Copy Markdown
Contributor Author

unnati-solanki-git commented May 22, 2026

LGTM. Quick question, how does the dashboard behave in case of onError: continue ? Does it log everything ? If so, I think we should add the onError: continue in all FVT tests to not block the whole suite test.

I did a small check with similar config to understand exact behaviour. The task will still report failure but will not fail the pipeline and continue with next task in sequence.

More details here - https://ibm-mas.slack.com/archives/C0A6RLMP614/p1779390573568699?thread_ts=1779361593.751849&cid=C0A6RLMP614

@unnati-solanki-git unnati-solanki-git requested a review from durera May 22, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terc1997 terc1997 terc1997 left review comments

@joaopauloksn joaopauloksn Awaiting requested review from joaopauloksn

@RexMCM RexMCM Awaiting requested review from RexMCM

@durera durera Awaiting requested review from durera

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unnati-solanki-git @terc1997