[patch] MAS and Manage RBAC Permissions in Install pipeline#2248
Open
unnati-solanki-git wants to merge 42 commits into
Open
[patch] MAS and Manage RBAC Permissions in Install pipeline#2248unnati-solanki-git wants to merge 42 commits into
unnati-solanki-git wants to merge 42 commits into
Conversation
unnati-solanki-git
changed the title
durera
reviewed
May 20, 2026
| echo "For help reviewing the content of the must gather refer to:" | ||
| echo "https://www.ibm.com/support/pages/how-review-maximo-application-suite-must-gather" | ||
|
|
||
| if [ "$(oc whoami 2>/dev/null)" == "" ] ; then |
Contributor
There was a problem hiding this comment.
Even if we don't require use to be a cluster admin (second check), we still want the first check (that they are logged into the cluster) ?
| - kind: ServiceAccount | ||
| name: mas-{{ mas_instance_id }}-install-pipeline | ||
| namespace: mas-{{ mas_instance_id }}-pipelines | ||
| - kind: ServiceAccount |
Contributor
There was a problem hiding this comment.
why do we need to bind to this service account as well?
If user is using the OOTB "pipeline" account it means they have chosen to go for the "just set me up the default account with cluster admin permissions still doesn't it?
Contributor
Author
There was a problem hiding this comment.
Thanks for the noticing! This was added to test must-gather related changes, but forgot to clean up. Removed now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jsw.ibm.com/browse/MASCORE-13654