Enhance event loop handling in Event class and utility functions#9
Open
Enhance event loop handling in Event class and utility functions#9
Conversation
…dress #8 - Added check to prevent running Event.run() within an already running asyncio event loop. - Implemented cleanup of pending tasks after running the event list. - Updated get_event_loop() to handle different scenarios for retrieving the asyncio event loop.
Collaborator
Author
|
py314 is working fine with this fix. https://github.com/ib-api-reloaded/eventkit/actions/runs/21177052468/job/60909715662?pr=9#step:8:111 Please note that, now we get the deprecation warning with get_event_loop_policy, but not with dev/eventkit/eventkit/util.py:27: DeprecationWarning: 'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16
return asyncio.get_event_loop_policy().get_event_loop() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #8