Skip to content

[PWGDQ] Please consider the following formatting changes to #8744 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iarsene merged 1 commit into from
Nov 29, 2024
Merged

[PWGDQ] Please consider the following formatting changes to #8744 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions PWGDQ/Core/MCSignal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
//

Check warning on line 11 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.

Check warning on line 11 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

Check warning on line 11 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \author is missing, incorrect or misplaced.
// Contact: iarsene@cern.ch, i.c.arsene@fys.uio.no
//
/* Schematic Monte Carlo signal definition:
Expand Down Expand Up @@ -40,14 +40,14 @@
}
process(aod::McParticles const& mcTracks) {
...
for (auto& mctrack : mcTracks) {

Check warning on line 43 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if(mySignal.CheckSignal(true,mcTracks,mctrack)) {
cout << "Found signal" << endl;

Check warning on line 45 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Consider using O2 logging (LOG, LOGF, LOGP).
}
}
for (auto& [mt1, mt2] : combinations(mcTracks, mcTracks)) {

Check warning on line 48 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if(mySignal2.CheckSignal(true,mcTracks,mt1,mt2)) {
cout << "Match found for " << mySignal2.GetName() << endl;

Check warning on line 50 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Consider using O2 logging (LOG, LOGF, LOGP).
}
}
}
Expand All @@ -60,7 +60,7 @@
#include "TNamed.h"

#include <vector>
#include <iostream>

Check warning on line 63 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[include-iostream] 

Including iostream is discouraged. Use O2 logging instead.

class MCSignal : public TNamed
{
Expand Down Expand Up @@ -113,12 +113,12 @@
void PrintConfig();

private:
std::vector<MCProng> fProngs; // vector of MCProng
unsigned int fNProngs; // number of prongs
std::vector<MCProng> fProngs; // vector of MCProng
unsigned int fNProngs; // number of prongs
std::vector<int8_t> fCommonAncestorIdxs; // index of the most recent ancestor, relative to each prong's history
bool fExcludeCommonAncestor; // explicitly request that there is no common ancestor
bool fDecayChannelIsExclusive; // if true, then the indicated mother particle has a number of daughters which is equal to the number of prongs defined in this MC signal
bool fDecayChannelIsNotExclusive; // if true, then the indicated mother particle has a number of daughters which is larger than the number of prongs defined in this MC signal
bool fExcludeCommonAncestor; // explicitly request that there is no common ancestor
bool fDecayChannelIsExclusive; // if true, then the indicated mother particle has a number of daughters which is equal to the number of prongs defined in this MC signal
bool fDecayChannelIsNotExclusive; // if true, then the indicated mother particle has a number of daughters which is larger than the number of prongs defined in this MC signal
int fTempAncestorLabel;

template <typename T>
Expand Down Expand Up @@ -194,7 +194,7 @@
}
if (currentMCParticle.has_daughters() && j < fProngs[i].fNGenerations - 1) {
const auto& daughtersSlice = currentMCParticle.template daughters_as<P>();
for (auto& d : daughtersSlice) {

Check warning on line 197 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (fProngs[i].TestPDG(j + 1, d.pdgCode())) {
currentMCParticle = d;
break;
Expand Down Expand Up @@ -265,7 +265,7 @@
}
if (currentMCParticle.has_daughters() && j < fProngs[i].fNGenerations - 1) {
const auto& daughtersSlice = currentMCParticle.template daughters_as<P>();
for (auto& d : daughtersSlice) {

Check warning on line 268 in PWGDQ/Core/MCSignal.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (fProngs[i].TestPDG(j + 1, d.pdgCode())) {
currentMCParticle = d;
break;
Expand Down
Loading