fix: respect brvPath parameter and add high-value tests (vitest)#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a patch release for the
opencode-byteroverplugin, focusing on improving configuration handling, adding high-value automated tests, and ensuring proper parameter passthrough to the underlying bridge. The update also includes minor dependency bumps and workflow/test script enhancements to improve reliability and maintainability.Key changes:
Testing and Quality Assurance
src/index.test.ts) covering plugin configuration, recall, curation deduplication, and error handling. This suite ensures observable plugin behavior is robust and exposes a real bug in default options handling. ([[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-258035e5968f6bf645400d417f310218d7d9a9a10606a3c34e7f55db193f58f3R1-R141),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-5c8683f45d6c3d09b262c4859efef082fd4e4a4e1a4acc01b8bdd4d3e5c1fab8R1-R60))pnpm testscript and integrated it into CI and pre-commit hooks for automated verification. ([[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R33-R41),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L51-R53),[[3]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR46-R48),[[4]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-d2bc4bbf14eadc292d84e0ef5f7a93115c23557f533809fc80b896934291529dR3),[[5]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R54))Configuration and Bug Fixes
Config.safeParse(options ?? {}). ([[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80L6-R27),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-5c8683f45d6c3d09b262c4859efef082fd4e4a4e1a4acc01b8bdd4d3e5c1fab8R1-R60))brvPathparameter is correctly respected and passed to theBrvBridge, along with other relevant configuration options. ([[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80L47-L56),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80L24-R36))Dependency and Documentation Updates
@opencode-ai/pluginand@opencode-ai/sdkdependencies to^1.14.24and addedvitestas a dev dependency. ([[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R33-R41),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L51-R53))[[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R54),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-18d30e2301ac02f59da39d741c0b51a77126197f529acb297e4e0febd695265bR1-R5))Context and Audit
[[1]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-754a1b97213f24b9a09cfe58d47d6743a40a346db0e5e0c1796a6b22d465abfdR1-R47),[[2]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-5c8683f45d6c3d09b262c4859efef082fd4e4a4e1a4acc01b8bdd4d3e5c1fab8R1-R60),[[3]](https://github.com/ian-pascoe/opencode-byterover/pull/7/files#diff-af8375afa1723c9c45310f02518bc27aa88cddb53839b630a4c31f0ea1d4f8cdR1-R33))These changes collectively improve plugin reliability, testability, and maintainability, while ensuring configuration and context handling are robust and well-documented.