feat: add room capacity tolerance (10% for lecture rooms), fix teache…

[iamajaykr06]

Description

This PR implements room capacity tolerance for lecture classrooms and fixes the teacher-wise summary API issue.

Changes Made:

1. Room Capacity Tolerance (10% for Lecture Rooms)

   • Modified can_accommodate() in scheduler_new/models.py
   • Lecture rooms: Allow 10% over-capacity (45-seat room accepts 50 students)
   • Lab rooms: Strict check - no tolerance (can't create extra workstations)

2. Fix Teacher-wise Summary API

   • Added missing getSummary() method to workloadService
   • Endpoint: GET /workload/summary
   • Now loads teacher workload data in the Summary tab

Why These Changes:

• Room Capacity: Real universities accept 5-10% over-capacity in lecture halls (extra chairs, shared seating), but labs need strict limits (fixed equipment)
• Teacher Summary: Frontend was calling a method that didn't exist, causing the summary tab to fail

Fixes # (room capacity mismatch issues)
Fixes # (teacher-wise summary not loading)

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement

Changes Made

List the specific files and changes made:

• backend/app/scheduler_new/models.py

  • Updated can_accommodate() to apply 10% tolerance only for non-lab rooms
  • Labs use strict capacity check (no tolerance)

• frontend/src/services/resources.service.ts

  • Added getSummary() method to workloadService
  • Added rebalanceAll() method to workloadService

• frontend/src/pages/WorkloadPage.tsx

  • Added rebalance button and handler (subsequently removed per user preference)
  • Added summary loading functionality

• .github/PULL_REQUEST_TEMPLATE.md

  • Updated checklist with more comprehensive items

Testing

Describe the tests you ran to verify your changes:

• Tested locally (backend + frontend)
• All existing tests pass
• Added new tests for new functionality

Test Scenarios:

1. Room capacity: 50 students in 45-seat lecture room → ✅ Accepted (45 + 10% = 49.5, allows 50)
2. Room capacity: 50 students in 45-seat lab room → ❌ Rejected (strict check)
3. Teacher summary: WorkloadPage Summary tab → ✅ Loads teacher workload data correctly

Screenshots (if applicable)

N/A - Backend logic changes

Checklist

• My code follows the project's code style
• I have performed a self-review of my code
• I have commented my code where necessary
• I have updated the documentation accordingly
• My changes generate no new warnings
• I have added tests that prove my fix/feature works

Additional Notes

Room Capacity Logic:

• Lecture rooms: effective_capacity = capacity * 1.10 → allows 10% over-capacity
• Lab rooms: effective_capacity = capacity → strict limit, no tolerance

API Changes:

• New method: workloadService.getSummary() → calls GET /workload/summary
• Returns: Array of teacher objects with course count, total hours, and assignments

[github-actions]

AIPCSS Bot Reviewer Report

Status: All Quality Checks Passed

---

AI Logic Review

null

---

Backend Report

Passed: Backend quality checks passed.

---

Frontend Report

Passed: Frontend quality checks passed.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: All checks passed. Approved!

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: Please fix the issues mentioned in the report.

[github-actions]

Bot Reviewer: All checks passed. Approved!