Merged
Conversation
Collaborator
|
This does not require an MSP version bump; we didn't do that for the introduction of MSP2. |
DzikuVx
requested changes
Apr 1, 2022
| } | ||
| break; | ||
| #ifdef USE_PROGRAMMING_FRAMEWORK | ||
| case MSP2_INAV_LOGIC_CONDITIONS: |
Member
There was a problem hiding this comment.
@Scavanger this is a no-go. We can not change the current MSP frame to have a completely different structure.
Instead of changing MSP2_INAV_LOGIC_CONDITIONS let's do the following:
- Leave
MSP2_INAV_LOGIC_CONDITIONSunchanged - Add
MSP2_INAV_LOGIC_CONDITIONS_SINGLEframe - Switch configurator to use
MSP2_INAV_LOGIC_CONDITIONS_SINGLE
DzikuVx
approved these changes
Apr 5, 2022
DzikuVx
approved these changes
Apr 12, 2022
Collaborator
|
@Scavanger , couple of questions / comments.
|
Contributor
Author
|
@stronnag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #7783