Needs testing: Issue #10830 Surface Mode Fixes#11425
Conversation
|
There was a guy on Discord today who also experienced a similar issue to this. This was the transcript.
Note that he said he turned off the landing detector in this Diff, after the crash. Thinking it might be related. There is also a slight issue with having altitude trusted below 10cm. And not just what defines TRUSTED ? DIFF - INAV_9.0.1_cli_20260516_015624 (nav_disarm_on_landing = OFF after crash).txt |
|
@Jetrell Yes it's the same issue as #10830. The surface logic isn't very sophisticated when the AGL altitude isn't trusted. If you switch on Althold above the range finders useable range, so it isn't trusted, it simply descends at 0.5m/s until it gets back in range and becomes trusted. When this happens the throttle stick becomes useless, high or low ... it does nothing which is pretty confusing for the pilot. Maybe the throttle stick should control the descent speed in these circumstances when AGL isn't trusted, e.g. 0.5 m/s above mid throttle with a linear increase up to say 2 m/s from throttle mid to throttle low. Would make more sense to the pilot. Also the 0.5m/s is less than the landing detector minimum speed of 1 m/s which can cause it to trigger if the throttle is held low. Not sure why I chose 10cm as the detection cut off for this PR but it could be increased to maybe 50cm because detection is also only allowed in the PR if AGL altitude is trusted (that in itself would have prevented these crashes). Do you not have a rangefinder equipped quad @Jetrell to test this ? |
It is interesting about the 0.5m/s.. Emergency Landing descent speed is also 0.5m/s. Which I guess could also lead to a landing detector disarm if the throttle was lowered, if still in radio range. Increasing it to 50cm shouldn't be a problem from any lidar that works well enough to be worth using.. |
Should close #10830.
Inhibits landing detection when Surface mode active unless AGL altitude Trusted and below 50cm.
Changes behaviour in Surface mode without Trusted AGL altitude. Previously the craft would descend at 0.5m/s regardless of throttle stick position. PR changes this so the throttle stick provides some adjustment of the descent rate, 0.5 m/s from high to mid stick then linear increase up to 2 m/s at low stick position. Should be less confusing for the pilot to have some response from throttle control.
Provides OSD system message indicating Surface mode status.
Also updates OSD system message array size to take account of additional Geozone messages.
Needs testing.