feat: check app enclave configuration in preflight checks #667
+161
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erties in TeeService
|
jbern0rd
requested review from
Natchica,
Copilot,
nabil-Tounarti and
thewhitewizard
and removed request for
Natchica
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error handling in TEE services configuration by moving validation logic from PreComputeService to TeeServicesPropertiesService. The key change is that retrieveTeeServicesProperties now returns a list of WorkflowError instead of throwing exceptions, enabling better error propagation and handling.
- Enclave configuration validation (null checks, validity checks, heap size validation) is moved from
PreComputeService.runTeePreCompute()toTeeServicesPropertiesService.retrieveTeeServicesProperties() - Method
getTeeServicesPropertiesnow returns cached properties or null, whileretrieveTeeServicesPropertiesperforms validation and caching - Exception-based error handling replaced with
WorkflowErrorreturn values for better error flow control
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TeeServicesPropertiesService.java | Refactored to perform enclave validation and return WorkflowError list instead of throwing exceptions; properties now cached only on success |
| TeeService.java | Updated to call retrieveTeeServicesProperties and return its error list directly instead of catching exceptions |
| PreComputeService.java | Removed enclave configuration validation logic that was moved to TeeServicesPropertiesService |
| TeeSconeServiceTests.java | Updated tests to match new API (returns List<WorkflowError> instead of throwing exceptions); consolidated two test cases into one parameterized test |
| TeeServicesPropertiesServiceTests.java | Updated tests to validate new error-returning behavior instead of exception-throwing behavior; added new test cases for heap size validation |
| PreComputeServiceTests.java | Removed tests for enclave validation logic that was moved to TeeServicesPropertiesService |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Natchica
approved these changes
Nov 6, 2025
nabil-Tounarti
approved these changes
Nov 6, 2025
thewhitewizard
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.