Skip to content

Conversation

@ErwanDecoster
Copy link
Member

No description provided.

@ErwanDecoster ErwanDecoster self-assigned this Apr 24, 2025
@ErwanDecoster ErwanDecoster marked this pull request as ready for review April 24, 2025 14:00
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, see comments for improvements

import { graphql } from '@/graphql/gql';

export const dealsQuery = graphql(`
query Deals($length: Int = 20, $skip: Int = 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this adds compared to the way I currently use it.

import { graphql } from '@/graphql/gql';

export const appsQuery = graphql(`
query Apps($length: Int = 20, $skip: Int = 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live

import { graphql } from '@/graphql/gql';

export const datasetsQuery = graphql(`
query Datasets($length: Int = 20, $skip: Int = 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this adds compared to the way I currently use it.

import { graphql } from '@/graphql/gql';

export const taskQuery = graphql(`
query Tasks($length: Int = 20, $skip: Int = 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this adds compared to the way I currently use it.

import { graphql } from '@/graphql/gql';

export const workerpoolsQuery = graphql(`
query Workerpools($length: Int = 20, $skip: Int = 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this adds compared to the way I currently use it.

query: TypedDocumentString<TResult, TVariables>,
...[variables]: TVariables extends Record<string, never> ? [] : [TVariables]
) {
const subgraphUrl = import.meta.env.VITE_POCO_SUBGRAPH_URL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that the subgraphUrl will depend on the displayed chain

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the Multi-chain will be handled in another PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy button is widely used in preview tables, this may be suboptimal if we want the rows to be links to the detail page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good point! I think the line is wide enough and we can keep it as is, but indeed, it would be interesting to get more feedback on this topic.

@ErwanDecoster ErwanDecoster merged commit 9eeb2eb into main Apr 25, 2025
2 checks passed
@ErwanDecoster ErwanDecoster deleted the feature/add-home-page branch April 25, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants