-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add home page #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, see comments for improvements
| import { graphql } from '@/graphql/gql'; | ||
|
|
||
| export const dealsQuery = graphql(` | ||
| query Deals($length: Int = 20, $skip: Int = 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this adds compared to the way I currently use it.
| import { graphql } from '@/graphql/gql'; | ||
|
|
||
| export const appsQuery = graphql(` | ||
| query Apps($length: Int = 20, $skip: Int = 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live
| import { graphql } from '@/graphql/gql'; | ||
|
|
||
| export const datasetsQuery = graphql(` | ||
| query Datasets($length: Int = 20, $skip: Int = 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this adds compared to the way I currently use it.
| import { graphql } from '@/graphql/gql'; | ||
|
|
||
| export const taskQuery = graphql(` | ||
| query Tasks($length: Int = 20, $skip: Int = 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this adds compared to the way I currently use it.
| import { graphql } from '@/graphql/gql'; | ||
|
|
||
| export const workerpoolsQuery = graphql(` | ||
| query Workerpools($length: Int = 20, $skip: Int = 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include the @live directive in queries to thegraph network with refetchInterval
https://thegraph.com/docs/en/subgraphs/querying/graph-client/live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this adds compared to the way I currently use it.
| query: TypedDocumentString<TResult, TVariables>, | ||
| ...[variables]: TVariables extends Record<string, never> ? [] : [TVariables] | ||
| ) { | ||
| const subgraphUrl = import.meta.env.VITE_POCO_SUBGRAPH_URL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep in mind that the subgraphUrl will depend on the displayed chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the Multi-chain will be handled in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy button is widely used in preview tables, this may be suboptimal if we want the rows to be links to the detail page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point! I think the line is wide enough and we can keep it as is, but indeed, it would be interesting to get more feedback on this topic.
No description provided.