Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Dec 1, 2025

matchOrders:

image

assertDatasetDealCompatibility:

image

Copilot AI review requested due to automatic review settings December 1, 2025 16:04
@zguesmi zguesmi self-assigned this Dec 1, 2025
@zguesmi zguesmi marked this pull request as ready for review December 1, 2025 16:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the dataset order tag ignoring code by extracting the bit masking logic into a reusable private function _ignoreTeeFramework in the Solidity contract, and by expanding test coverage to validate all combinations of TEE tags. The refactoring improves code maintainability by eliminating duplicated masking logic, enhances documentation with clear examples, and increases test coverage from 4 to 25 test cases for cross-framework compatibility.

Key changes include:

  • Extraction of tag masking logic into _ignoreTeeFramework function
  • Enhanced documentation with inline examples showing tag compatibility
  • Comprehensive test coverage for all TEE tag combinations (5×5 matrix)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
contracts/facets/IexecPoco1Facet.sol Extracts duplicated tag masking logic into reusable _ignoreTeeFramework function and improves documentation with examples
utils/constants.ts Adds helper arrays (ALL_TEE_TAGS) and mappings (TAG_NAMES) to support comprehensive test iteration and updates comments to reference Solidity implementation
test/byContract/IexecPoco/IexecPoco1.test.ts Refactors tests to use nested forEach loops with ALL_TEE_TAGS, expanding coverage from 4 specific cases to 25 comprehensive combinations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (81778ee) to head (5985ac7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          33       33           
  Lines        1136     1137    +1     
  Branches      228      228           
=======================================
+ Hits         1095     1096    +1     
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi merged commit f50b898 into main Dec 1, 2025
4 checks passed
@zguesmi zguesmi deleted the refactor/use-common-code-for-bit-ignore branch December 1, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants