-
Notifications
You must be signed in to change notification settings - Fork 139
docs: fix an external link that moved #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The link to example agent.py path changed (and repo renamed). Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Summary of ChangesHello @markstur, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with outdated external links within the documentation. By updating the URL to a moved repository and file path, it ensures the accuracy and usability of the provided examples for users referencing the migration guide. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a broken external link in the ACP to A2A migration guide across both development and stable documentation versions. The updated link points to the correct, renamed repository and file path. My feedback includes suggestions to improve the link's presentation by using descriptive text instead of a raw URL, which enhances readability for users.
|
|
||
| 1. https://github.com/i-am-bee/agentstack/blob/main/agents/chat/src/chat/agent.py | ||
| 2. https://github.com/jenna-winkler/granite_chat/blob/main/src/beeai_agents/agent.py | ||
| 2. https://github.com/jenna-winkler/agentstack-showcase/blob/main/src/agentstack_agents/agent.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to provide more context to the reader, consider using descriptive link text instead of a raw URL. This makes the documentation more user-friendly.
2. [AgentStack Showcase Example](https://github.com/jenna-winkler/agentstack-showcase/blob/main/src/agentstack_agents/agent.py)
|
|
||
| 1. https://github.com/i-am-bee/agentstack/blob/main/agents/chat/src/chat/agent.py | ||
| 2. https://github.com/jenna-winkler/granite_chat/blob/main/src/beeai_agents/agent.py | ||
| 2. https://github.com/jenna-winkler/agentstack-showcase/blob/main/src/agentstack_agents/agent.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to provide more context to the reader, consider using descriptive link text instead of a raw URL. This makes the documentation more user-friendly.
2. [AgentStack Showcase Example](https://github.com/jenna-winkler/agentstack-showcase/blob/main/src/agentstack_agents/agent.py)
|
I would like to fix this in development and stable but the CI check fails when touching stable. Please let me know if this small fix should be done in development only (to be copied on release). |
Summary
The link to example agent.py path changed (and repo renamed).
Linked Issues
Closes #1894
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.