feat(agentstack-server): configurable CORS

[JanPokorny]

Signed-off-by: Jan Pokorný JenomPokorny@gmail.com

Summary

Linked Issues

Fixes #1888

Documentation

• No Docs Needed:

If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.

[gemini-code-assist]

Summary of Changes

Hello @JanPokorny, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the agentstack-server by implementing configurable Cross-Origin Resource Sharing (CORS). This allows administrators to precisely control which origins, methods, and headers are permitted to interact with the API, improving security and flexibility for integrating with various front-end applications. The changes include adding a dedicated CORS configuration model, integrating FastAPI's CORSMiddleware, and exposing these settings via Helm for easy deployment management.

Highlights

• Configurable CORS: Introduced configurable Cross-Origin Resource Sharing (CORS) for the agentstack-server application, allowing administrators to define allowed origins, methods, headers, and credentials.
• FastAPI Middleware Integration: Integrated FastAPI's CORSMiddleware into the application, which is conditionally enabled based on the new CORS configuration.
• CORS Configuration Model: Added a new CORSConfiguration Pydantic model to manage all CORS-related settings, including validation logic to prevent insecure configurations (e.g., allow_origins='*' with allow_credentials=True).
• Helm Chart Updates: Updated the Helm chart (deployment.yaml and values.yaml) to expose CORS settings, enabling deployment-time configuration of these parameters via environment variables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces configurable CORS support for the agentstack-server, which is a valuable addition for clients running on different origins. The implementation is well-structured, adding a CORSConfiguration model, integrating it with FastAPI's CORSMiddleware, and exposing the settings through the Helm chart. The code follows best practices, with secure defaults and validation for common misconfigurations. I have one suggestion to make the configuration validation stricter to improve the developer experience by failing fast on misconfigurations.