Skip to content

Conversation

@jjeliga
Copy link
Contributor

@jjeliga jjeliga commented Jan 22, 2026

Summary

When switching servers the app first tries to refresh the token and proceeds to login when it fails due to expired refresh token. The user is notified throughout the process

Linked Issues

CLoses #1833

Documentation

  • No Docs Needed: does not change the functionality in any way

Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
@jjeliga jjeliga requested a review from pilartomas January 22, 2026 11:06
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 22, 2026
Copy link
Contributor

@pilartomas pilartomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, client_id default is the only blocker, other stuff is nice to have 👍

Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 22, 2026
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
@jjeliga jjeliga requested a review from pilartomas January 23, 2026 07:10
Copy link
Contributor

@pilartomas pilartomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

from authlib.oauth2.rfc6749.errors import InvalidGrantError, OAuth2Error
from pydantic import BaseModel, Field

TOKEN_EXPIRY_BUFFER = 60 # seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common name is leeway

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

CLI - Expired tokens not handled when switching authenticated servers

3 participants