-
Notifications
You must be signed in to change notification settings - Fork 139
fix(cli): improved flow when refresh token expires #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
pilartomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, client_id default is the only blocker, other stuff is nice to have 👍
Signed-off-by: Jan Jeliga <jeliga.jan@gmail.com>
pilartomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| from authlib.oauth2.rfc6749.errors import InvalidGrantError, OAuth2Error | ||
| from pydantic import BaseModel, Field | ||
|
|
||
| TOKEN_EXPIRY_BUFFER = 60 # seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common name is leeway
Summary
When switching servers the app first tries to refresh the token and proceeds to login when it fails due to expired refresh token. The user is notified throughout the process
Linked Issues
CLoses #1833
Documentation