-
Notifications
You must be signed in to change notification settings - Fork 139
docs: fix broken links #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: fix broken links #1869
Conversation
Summary of ChangesHello @markstur, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the integrity and user experience of the documentation by resolving a widespread issue of broken links. The changes primarily involve updating link structures to use relative paths, making the documentation more robust to changes in its deployment environment or internal organization. Additionally, links to non-existent examples have been removed, and minor textual errors have been corrected, ensuring a more accurate and navigable resource for users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a comprehensive fix for broken links and typos throughout the documentation. By converting absolute links to relative paths for both stable and development versions, the changes significantly improve the documentation's maintainability. The PR also corrects several typos and removes links to pages that are no longer available, as noted in the summary. The fixes are consistent and well-executed across all modified files. This is an excellent contribution that enhances the quality and accuracy of the documentation. I found no issues with the proposed changes.
|
I'm afraid relative links were probably avoided for some good reasons, but it looks to me like the best way to maintain development and stable right now. If we have some known issues with that, we can work on some automation. It would be nice to fix the broken docs first. |
Many links were broken due to stable and development roots. Addition links broken due to rearranging. Examples links are for examples that just don't exist yet. * Use relative links to help maintain stable and development * Misc fixes to links and typos * Remove the links to missing examples for now * Fixes here are only in development. Fixes i-am-bee#1856 - [x] No Docs Needed: This is doc fixing. Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
|
@tomkis the relative links are great for local doc serving and dev. Fixing so many 404s and the copy from dev to stable doesn't need swizzling. Any feedback on this approach? |
Summary
many links were broken due to stable and development roots
addition links broken due to rearranging
examples links just don't exist
Use relative links to help maintain stable and development
Misc fixes to links and typos
Remove the links to missing examples for now
Linked Issues
Fixes #1856
Fixes #1884
Documentation
This is doc fixing.