-
Notifications
You must be signed in to change notification settings - Fork 139
chore: TS SDK experimental server #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @tomkis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a foundational experimental server to the TypeScript SDK, significantly enhancing its capability to host and manage agents. The new server provides features for agent definition, automatic platform registration, and a robust execution environment that supports various extensions for services like LLMs and detailed UI configurations. This architectural shift aims to streamline agent development and deployment within the SDK, accompanied by a refactoring of shared data structures for improved organization. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an experimental server for the TypeScript SDK, which is a significant and well-implemented feature. The changes include adding an express-based server, an example agent, and refactoring shared schemas and types into a shared directory, which improves code organization. The new server implementation is robust, featuring auto-registration with retry logic and graceful shutdown handling.
My review focuses on improving correctness, maintainability, and robustness. I've pointed out a type mismatch in an interface, suggested improvements to error handling and logging to avoid swallowing errors, and recommended deduplicating some logic to improve maintainability. Overall, this is a solid contribution.
apps/agentstack-sdk-ts/src/experimental/server/autoregistration.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/experimental/server/autoregistration.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/experimental/server/autoregistration.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/experimental/server/autoregistration.ts
Outdated
Show resolved
Hide resolved
apps/agentstack-sdk-ts/src/experimental/server/autoregistration.ts
Outdated
Show resolved
Hide resolved
105747b to
c5a6532
Compare
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
a012c82 to
98d3a5e
Compare
| "dev": "microbundle watch src/*.ts" | ||
| "build": "tsup", | ||
| "dev": "tsup --watch", | ||
| "example:hello-world": "tsx watch src/examples/hello-world.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to have this in package.json as it's part of an experimental feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, let's prefix this with experimental
| description: options.description ?? '', | ||
| url: 'http://localhost:8000', | ||
| version: options.version ?? '1.0.0', | ||
| protocolVersion: '0.2.2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this protocol version correct?
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Summary
Linked Issues
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.