Open
Conversation
1. add try catch in operations function. 2. add function to recognize p2wpkh(pay to witness public key hash) script. 3. add function to recoginze p2wsh(pay to witness script hash) script.
no extra comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add some changes in script.py, I find that some PKscript in output are illegal, the list(self.script) may cause CScriptInvalidError, I add a try catch sentence.
I also add two functions (is_p2wpkh and is_p2wsh) to recoginze segregate PKscripts, according to the two functions, I also alert the is_unknown function.
I have test the functions aforementioned from genesis block to 620000th block, and all of them worked correctly.