Skip to content

Remove transaction isolation level config in PG#306

Open
suddendust wants to merge 1 commit intomainfrom
pg_removeIsolationLevelConfig
Open

Remove transaction isolation level config in PG#306
suddendust wants to merge 1 commit intomainfrom
pg_removeIsolationLevelConfig

Conversation

@suddendust
Copy link
Copy Markdown
Contributor

@suddendust suddendust commented May 5, 2026

Description

This PR removes poolableConnectionFactory.setDefaultTransactionIsolation(TRANSACTION_READ_COMMITTED);. TRANSACTION_READ_COMMITTED is already the default - However, setting this setting it explicitly causes DBCP2 to execute SHOW TRANSACTION ISOLATION LEVEL on every connection borrow which is highly sub-optimal. We observed that with this configuration, getPooledConnection is almost ~ 50% of the wall-clock time in executeUpsert call. However, with this removed, it's ~ 0.46%.

With Config:

Screenshot 2026-05-05 at 2 02 11 PM

Without Config (the frame for getPooledConnection is not visible since it's so small):

Screenshot 2026-05-05 at 2 02 56 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.73%. Comparing base (daf5ccb) to head (e3cabb0).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #306      +/-   ##
============================================
- Coverage     81.73%   81.73%   -0.01%     
  Complexity     1532     1532              
============================================
  Files           241      241              
  Lines          7413     7412       -1     
  Branches        717      717              
============================================
- Hits           6059     6058       -1     
  Misses          908      908              
  Partials        446      446              
Flag Coverage Δ
integration 81.73% <ø> (-0.01%) ⬇️
unit 55.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Test Results

  122 files  ±0    122 suites  ±0   39s ⏱️ ±0s
  829 tests ±0    828 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 166 runs  ±0  1 165 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit e3cabb0. ± Comparison against base commit daf5ccb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants