Fix test-framework resolution and hs-Cpp compilation across platforms#31
Open
Fix test-framework resolution and hs-Cpp compilation across platforms#31
Conversation
- Remove explicit version from testFramework() — let the plugin resolve it automatically from the configured platform dependency - Extract makeCmakeExecutable() into platform-specific branches: 252/253 use getBundledCMakeToolBinary(Boolean, ToolKind) API, 261 uses getBundledCMakeToolBinary(ToolKind) API Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
meanmail
force-pushed
the
fix-ci-and-tests
branch
from
d6c6227 to
4dfecb1
Compare
meanmail
changed the title
Module tests (hs-core, hs-Java, etc.) cannot run directly because prepareSandbox is disabled in modules, leaving IntelliJ Platform jars off the test runtime classpath. Run :intellij-plugin:test (which includes hs-core tests) plus standalone module tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-frameworkdependency resolution — remove explicit version parameter so IntelliJ Platform Gradle Plugin resolves it automatically from the configured platformhs-Cppcompilation across all platforms (252, 253, 261) by adding platform-specificcmakeCompat.ktwith the correctcmakedependency resolutionTest plan
hs-Cppmodule compiles successfully on all platformshs-coretests can resolvetest-frameworkand run🤖 Generated with Claude Code