Skip to content

Check dataset integrity#234

Open
ddevin96 wants to merge 28 commits into
mainfrom
feat/dataset-integrity
Open

Check dataset integrity#234
ddevin96 wants to merge 28 commits into
mainfrom
feat/dataset-integrity

Conversation

@ddevin96
Copy link
Copy Markdown
Collaborator

@ddevin96 ddevin96 commented May 20, 2026

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there are no other open Pull Requests for the same changes?
  • Have you made sure you have rebased your branch to the latest commit on the target branch?

Description

  • Added integration test folder + make command
  • Resolved data ambiguity in dataset

This will close #164 #165

Checklist

  • Does your submission pass all tests? (use make test)
  • Have you written tests to cover all your changes? If not, provide a reason.
  • Have you lint your code locally before submission? (use make format)
  • Have you type checked your code locally before submission? (use make typecheck)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@tizianocitro tizianocitro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think integration tests should run in each PR separated from the normal unit tests. I'd run them on OS latest versions for now. We should also look into whether there's a way to parallelize tests in Python.

Comment thread hyperbench/utils/data_utils.py Outdated
Comment thread hyperbench/integration_tests/hlp/cn_integration_test.py
Comment thread hyperbench/tests/data/supported_datasets_test.py Outdated
Comment thread hyperbench/tests/data/supported_datasets_test.py Outdated
Comment thread hyperbench/tests/data/supported_datasets_test.py Outdated
Comment thread hyperbench/tests/data/supported_datasets_test.py Outdated
Comment thread hyperbench/tests/data/supported_datasets_test.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci data docs Improvements or additions to documentation feature tests types utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add list_datasets function

2 participants