fix: Info.query_order_by_oid returns unknownOid sometimes#268
Open
domiclaw wants to merge 1 commit intohyperliquid-dex:masterfrom
Open
fix: Info.query_order_by_oid returns unknownOid sometimes#268domiclaw wants to merge 1 commit intohyperliquid-dex:masterfrom
domiclaw wants to merge 1 commit intohyperliquid-dex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #253 where
Info.query_order_by_oidwas returning "unknownOid" when querying orders on non-default DEXes. The root cause was that the method was missing thedexparameter that other order-related methods (open_orders, etc.) support.Changes
dex: str = ""parameter toInfo.query_order_by_oid()methoddex: str = ""parameter toInfo.query_order_by_cloid()method for consistencydexparameter in the API request bodyTesting
dex="")open_orders(dex="..."), you must now pass the samedexvalue toquery_order_by_oid()to locate the orderFixes #253