Skip to content

fix: Info.query_order_by_oid returns unknownOid sometimes#268

Open
domiclaw wants to merge 1 commit intohyperliquid-dex:masterfrom
kyaky:fix/issue-253
Open

fix: Info.query_order_by_oid returns unknownOid sometimes#268
domiclaw wants to merge 1 commit intohyperliquid-dex:masterfrom
kyaky:fix/issue-253

Conversation

@domiclaw
Copy link

@domiclaw domiclaw commented Mar 2, 2026

Summary

This PR fixes issue #253 where Info.query_order_by_oid was returning "unknownOid" when querying orders on non-default DEXes. The root cause was that the method was missing the dex parameter that other order-related methods (open_orders, etc.) support.

Changes

  • Added dex: str = "" parameter to Info.query_order_by_oid() method
  • Added dex: str = "" parameter to Info.query_order_by_cloid() method for consistency
  • Updated both methods to pass the dex parameter in the API request body
  • Added comprehensive docstrings documenting the new parameter

Testing

  • Existing tests pass where network requests are mocked
  • The fix maintains backward compatibility (default dex="")
  • When querying orders fetched via open_orders(dex="..."), you must now pass the same dex value to query_order_by_oid() to locate the order

Fixes #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Info.query_order_by_oid returns unknownOid sometimes

1 participant