Fix E2E report job failing when E2E is skipped#196
Merged
nicnocquee merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The merge Playwright report job ran whenever the workflow finished, including when the
e2ematrix was skipped (for example after a merge push tomain). With no blob artifacts,playwright merge-reportsexited with code 1 and failed the workflow.The merge job now runs only when
e2eactually completed with success or failure, so skippede2eruns no longer break CI.Important changes
e2e_reportonneeds.e2e.resultbeingsuccessorfailure, and skip when the workflow run was cancelled.Other changes
Key files to review
.github/workflows/e2e.yml—e2e_reportif:condition.How to test
main(non-direct) and confirm the E2E workflow completes green whilee2eis skipped.