Combine type error messages into a single meaningful error #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add normalization handlers - Add error handlers - Fix type handling and numeric count/matchCount constraints - Update draft-04 test suite
feat(draft-04): add support for JSON Schema Draft-04 keywords - Add normalization handlers - Add error handlers - Fix type handling and numeric count/matchCount constraints - Update draft-04 test suite A fix normalization and error handlers Signed-off-by: Diya <diyasrivastava2023@gmail.com> fix: normalization and error handlers for draft-04 fix type checks revert minimum and maximum error handler
Signed-off-by: Diya <diyasrivastava2023@gmail.com>
Signed-off-by: Diya <diyasrivastava2023@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #133
Currently, when multiple type keywords apply at the same instance location (e.g. through allOf), the validator emits multiple type error messages, which results in noisy output for users.
Changes made
Notes
getUnknownErrorMessage("type")when no valid type remains