fix: poll_capacity must not return Ready(Some(Ok(0)))#898
Open
ArniDagur wants to merge 1 commit intohyperium:masterfrom
Open
fix: poll_capacity must not return Ready(Some(Ok(0)))#898ArniDagur wants to merge 1 commit intohyperium:masterfrom
ArniDagur wants to merge 1 commit intohyperium:masterfrom
Conversation
A WINDOW_UPDATE and SETTINGS decrease in the same poll can cancel each other out, resulting in zero capacity. Return `Pending`, rather than `Ready(Ok(0))`. See hyperium#270
ArniDagur
force-pushed
the
fix/poll-capacity-zero-after-settings-decrease
branch
from
62030d1 to
0d7e1a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WINDOW_UPDATE and SETTINGS decrease in the same poll can cancel each other out, resulting in zero capacity.
Return
Pending, rather thanReady(Ok(0)). See #270