Skip to content

[HDX-4236] chore: deprecate miner service#2266

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
warren/HDX-4236-deprecate-miner-service
May 13, 2026
Merged

[HDX-4236] chore: deprecate miner service#2266
kodiakhq[bot] merged 2 commits into
mainfrom
warren/HDX-4236-deprecate-miner-service

Conversation

@wrn14897
Copy link
Copy Markdown
Member

Summary

The Python miner service has been deprecated. It is dead code — nothing in the repo calls it at runtime:

  • packages/app mines patterns client-side using Pyodide-loaded drain3 (src/hooks/usePatterns.tsx)
  • packages/cli uses the TypeScript drain port in packages/common-utils/src/drain/
  • packages/api/src/config.ts exported MINER_API_URL but no code path imported it

Changes

Removed MINER_API_URL from:

  • packages/api/src/config.ts
  • packages/api/.env.development
  • docker-compose.yml

Verification

  • rg MINER_API_URL → 0 hits
  • yarn lint:fix → 0 errors

Linear

HDX-4236

Related

Companion EE PR: DeploySentinel/hyperdx-ee#2069

The Python miner service has been deprecated. The MINER_API_URL env var
was exported from the API config but never imported anywhere — the app
mines patterns client-side via Pyodide-loaded drain3 and the CLI uses
the TypeScript drain port in common-utils.

Removes MINER_API_URL from api config, .env.development, and
docker-compose.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

⚠️ No Changeset found

Latest commit: 966d039

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hyperdx-oss Ignored Ignored Preview May 13, 2026 1:07pm

Request Review

@github-actions github-actions Bot added the review/tier-4 Critical — deep review + domain expert sign-off label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

  • Critical-path files (1):
    • packages/api/src/config.ts

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats
  • Production files changed: 3
  • Production lines changed: 3
  • Branch: warren/HDX-4236-deprecate-miner-service
  • Author: wrn14897

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

<!-- claude-code-review -->

PR Review

✅ No critical issues found.

  • Clean deletion of dead config: MINER_API_URL removed from packages/api/src/config.ts, packages/api/.env.development, and docker-compose.yml.
  • Verified rg MINER_API_URL returns 0 hits across the repo. No miner-service references remain in any docker-compose file or under packages/api/.
  • Remaining "miner" matches are unrelated (client-side Pyodide Miner in packages/app/src/hooks/usePatterns.tsx and the TS drain port TemplateMiner in packages/common-utils/src/drain/) — correctly out of scope.

Note: confirm the companion EE PR (DeploySentinel/hyperdx-ee#2069) lands together so no EE code still imports MINER_API_URL from the OSS config.

@github-actions
Copy link
Copy Markdown
Contributor

<!-- deep-review -->

Deep Review

✅ No critical issues found.

Pure 3-line removal of the dead MINER_API_URL export and its sibling env declarations in docker-compose.yml, packages/api/.env.development, and packages/api/src/config.ts. Independently verified: zero remaining MINER_API_URL or miner:5123 references at HEAD, and no miner: service block in any docker-compose*.yml. Other miner identifiers in the repo (TemplateMiner in packages/common-utils/src/drain/, the client-side Miner class in packages/app/src/hooks/usePatterns.tsx) are unrelated log-pattern utilities running in Pyodide / the TS drain port, not callers of the deprecated Python service.


Reviewers (6): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

E2E Test Results

All tests passed • 176 passed • 3 skipped • 1223s

Status Count
✅ Passed 176
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@github-actions
Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

Pure 3-line deletion of the dead MINER_API_URL export and its sibling env declarations in docker-compose.yml, packages/api/.env.development, and packages/api/src/config.ts. Independently verified at HEAD: zero remaining MINER_API_URL references, no miner: service block in any docker-compose*.yml, and the other surviving miner identifiers (TemplateMiner in packages/common-utils/src/drain/, the Miner class in packages/app/src/hooks/usePatterns.tsx, and the CLI's TemplateMiner usage in packages/cli/src/cli.tsx) are unrelated in-process log-pattern utilities running in Pyodide / the TS drain port — not callers of the deprecated Python service. @hyperdx/api is internal-only and config.ts is consumed only via @/config within packages/api/src/, so removing the exported constant has no public-API consumers. No standards violation: AGENTS.md and CLAUDE.md do not require a changeset for chore: dead-code removals.


Reviewers (6): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher.

@kodiakhq kodiakhq Bot merged commit b0905dd into main May 13, 2026
19 checks passed
@kodiakhq kodiakhq Bot deleted the warren/HDX-4236-deprecate-miner-service branch May 13, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-4 Critical — deep review + domain expert sign-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants