[HDX-4236] chore: deprecate miner service#2266
Conversation
The Python miner service has been deprecated. The MINER_API_URL env var was exported from the API config but never imported anywhere — the app mines patterns client-side via Pyodide-loaded drain3 and the CLI uses the TypeScript drain port in common-utils. Removes MINER_API_URL from api config, .env.development, and docker-compose.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🔴 Tier 4 — CriticalTouches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
|
<!-- claude-code-review --> PR Review✅ No critical issues found.
Note: confirm the companion EE PR (DeploySentinel/hyperdx-ee#2069) lands together so no EE code still imports |
|
<!-- deep-review --> Deep Review✅ No critical issues found. Pure 3-line removal of the dead Reviewers (6): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher. |
E2E Test Results✅ All tests passed • 176 passed • 3 skipped • 1223s
Tests ran across 4 shards in parallel. |
Deep Review✅ No critical issues found. Pure 3-line deletion of the dead Reviewers (6): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher. |
Summary
The Python
minerservice has been deprecated. It is dead code — nothing in the repo calls it at runtime:packages/appmines patterns client-side using Pyodide-loadeddrain3(src/hooks/usePatterns.tsx)packages/cliuses the TypeScript drain port inpackages/common-utils/src/drain/packages/api/src/config.tsexportedMINER_API_URLbut no code path imported itChanges
Removed
MINER_API_URLfrom:packages/api/src/config.tspackages/api/.env.developmentdocker-compose.ymlVerification
rg MINER_API_URL→ 0 hitsyarn lint:fix→ 0 errorsLinear
HDX-4236
Related
Companion EE PR: DeploySentinel/hyperdx-ee#2069