Skip to content

fix: Override --mantine-color-text with semantic --color-text token#1950

Merged
kodiakhq[bot] merged 2 commits intomainfrom
feat/override-mantine-color-text
Mar 20, 2026
Merged

fix: Override --mantine-color-text with semantic --color-text token#1950
kodiakhq[bot] merged 2 commits intomainfrom
feat/override-mantine-color-text

Conversation

@elizabetdev
Copy link
Contributor

Summary

  • Override Mantine's --mantine-color-text CSS variable to use our semantic --color-text token in both themes (hyperdx and clickstack), for both dark and light modes.
  • Ensures all Mantine components that rely on --mantine-color-text use the correct theme-aware text color.
  • Overrides are placed in the /* Mantine Overrides */ section at the end of each theme mixin, consistent with the existing --mantine-color-body override.

Test plan

  • Verify text color in Mantine components matches the theme's --color-text in dark mode (both themes)
  • Verify text color in Mantine components matches the theme's --color-text in light mode (both themes)

Made with Cursor

Map Mantine's built-in --mantine-color-text CSS variable to our
semantic --color-text token in both hyperdx and clickstack themes
(dark and light modes). Placed in the Mantine Overrides section
at the end of each theme mixin.

Made-with: Cursor
@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 20, 2026 6:57pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2026

🦋 Changeset detected

Latest commit: 1fdb48d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

PR Review

  • ⚠️ Inconsistent !important usage in dark mode: Both themes use --mantine-color-body: var(--color-bg-body) !important in dark mode, but the new --mantine-color-text is added without !important. If !important was needed for the body color override to win specificity in dark mode, the same may apply to text color — and the fix may silently not work in dark mode for both themes. Verify Mantine doesn't set --mantine-color-text with higher specificity in dark mode, or add !important to match the existing pattern.

Otherwise the change is minimal, well-scoped, and consistent with the existing --mantine-color-body override pattern.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

E2E Test Results

All tests passed • 90 passed • 3 skipped • 994s

Status Count
✅ Passed 90
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq kodiakhq bot merged commit e1cf4bc into main Mar 20, 2026
14 checks passed
@kodiakhq kodiakhq bot deleted the feat/override-mantine-color-text branch March 20, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants