feat: Enhance data source select with context-aware icons and inline actions by elizabetdev · Pull Request #1948 · hyperdxio/hyperdx

elizabetdev · 2026-03-20T14:45:14Z

Summary

Closes HDX-3784

Context-aware icons for all source kinds: The data source dropdown now shows icons for every source type — IconLogs for logs, IconConnection for traces, IconDeviceLaptop for sessions, and IconChartLine for metrics. Falls back to IconStack when no source is selected.
Inline source actions: "Create New Source" and "Edit Sources" actions are now part of the dropdown itself under an "Actions" group with a labeled separator, replacing the separate gear icon menu (SourceEditMenu).
Dependency update: Updated @tabler/icons-react from v3.5.0 to v3.40.0 to get IconConnection.
Fix: source management regression when HDX_LOCAL_DEFAULT_SOURCES is set: Before this PR, there were two ways to create/edit sources: (1) options inside the dropdown, which were hidden when HDX_LOCAL_DEFAULT_SOURCES is set, and (2) a gear icon button next to the dropdown, which was always visible. This PR removed the gear icon and kept only the dropdown options, but they were still configured to hide when HDX_LOCAL_DEFAULT_SOURCES is set — leaving users with no way to manage sources. Fixed by removing that guard so the dropdown options always appear.

Changes

packages/app/src/components/SourceSelect.tsx -- Dynamic left icon based on selected source kind (all 4 kinds: log, trace, session, metric), onEdit prop, grouped action items with icons, renderOption for source kind and action item icons. Removed hasLocalDefaultSources guard so source management actions are always available.
packages/app/src/components/SelectControlled.tsx -- Added onEdit callback support, fixed selected check to handle grouped data.
packages/app/src/DBSearchPage.tsx -- Removed SourceEditMenu component, added onEditSources callback, wired onEdit to SourceSelectControlled.
packages/app/styles/SourceSelectControlled.module.scss -- Group label separator styling with semantic --color-border token.
packages/app/package.json -- Updated @tabler/icons-react to ^3.39.0.

Test plan

Update from v3.5.0 to get IconConnection (added in v3.39) for the data source select enhancement. Made-with: Cursor

…actions Show IconConnection for trace sources, IconLogs for log sources, and IconStack as fallback. Move Create New Source and Edit Sources actions into the dropdown as a grouped section with icons, replacing the separate gear icon menu. Made-with: Cursor

changeset-bot · 2026-03-20T14:45:19Z

🦋 Changeset detected

Latest commit: e6a3f76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-03-20T14:45:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Mar 20, 2026 7:20pm

github-actions · 2026-03-20T14:47:05Z

PR Review

⚠️ @tabler/icons-react jump from 3.5 → 3.40 (35 minor versions) across 93 files → Verify no icons were renamed/removed in the broad codebase; this is a large jump with potential for silent breakage elsewhere (e.g., IconConnection is new, but others may have changed).
⚠️ package.json specifies ^3.39.0 but PR description says "Updated to v3.40.0" → Minor inconsistency; lock resolves to 3.40.0 which is fine, but the stated intent vs. constraint mismatch could cause confusion on next yarn upgrade.
✅ SelectControlled.tsx selected fix is correct: The old code used .find() with a true fallback for group objects (no value key), which would incorrectly mark any group-containing data as "selected". The new .some() implementation properly traverses nested items arrays.
✅ Removal of HDX_LOCAL_DEFAULT_SOURCES guard: Intentional fix per PR description — the guard was hiding source management options when the gear icon was also removed, leaving users with no way to manage sources. The fix is sound.
✅ Sentinel values _create_new_value / _edit_value: Moved to SelectControlledSpecialValues enum (good refactor). Collision with real source IDs is negligible assuming UUIDs.

No critical bugs or security issues found. The icon library version bump is the main risk to verify before merging.

…icons Refactor SourceSelect to utilize a context-aware mapping for option icons, enhancing the user experience by displaying relevant icons based on the source kind. The renderOption function has been updated to accommodate this new logic, improving the visual representation of options in the dropdown.

github-actions · 2026-03-20T14:50:11Z

E2E Test Results

✅ All tests passed • 91 passed • 3 skipped • 986s

Status	Count
✅ Passed	91
❌ Failed	0
⚠️ Flaky	2
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

The source settings menu was removed in favor of inline dropdown actions. Update global setup to wait for the source selector instead of the removed gear icon, and update the SearchPage page object and sources spec to interact with actions via the dropdown. Made-with: Cursor

The previous refactor removed the standalone SourceEditMenu gear icon and moved its actions into the SourceSelectControlled dropdown, but kept the hasLocalDefaultSources guard that hid those actions. Since the gear icon fallback no longer exists, users with HDX_LOCAL_DEFAULT_SOURCES set lost all access to "Create New Source" and "Edit Sources". Remove the hasLocalDefaultSources guard so the actions always appear in the dropdown when onCreate/onEdit callbacks are provided. Made-with: Cursor

Added new icons for session and metric sources in the SourceSelect component, improving visual differentiation of source types. The SourceKind enum now includes IconDeviceLaptop for sessions and IconChartLine for metrics, enhancing the user experience in the dropdown selection.

pulpdrew

LGTM, with one small suggestion

packages/app/src/components/SelectControlled.tsx

packages/app/src/components/SourceSelect.tsx

Replace hardcoded string values with SelectControlledSpecialValues enum and rename _edit_sources_value to _edit_value for generality. Made-with: Cursor

elizabetdev added 2 commits March 20, 2026 14:42

chore: update @tabler/icons-react to v3.40.0

4ed54e2

Update from v3.5.0 to get IconConnection (added in v3.39) for the data source select enhancement. Made-with: Cursor

vercel bot deployed to Preview March 20, 2026 14:48 View deployment

vercel bot deployed to Preview March 20, 2026 14:53 View deployment

vercel bot deployed to Preview March 20, 2026 15:04 View deployment

vercel bot deployed to Preview March 20, 2026 16:52 View deployment

vercel bot deployed to Preview March 20, 2026 18:00 View deployment

pulpdrew previously approved these changes Mar 20, 2026

View reviewed changes

packages/app/src/components/SelectControlled.tsx Outdated Show resolved Hide resolved

packages/app/src/components/SourceSelect.tsx Outdated Show resolved Hide resolved

packages/app/src/components/SourceSelect.tsx Show resolved Hide resolved

refactor: extract special select values into enum

4a54426

Replace hardcoded string values with SelectControlledSpecialValues enum and rename _edit_sources_value to _edit_value for generality. Made-with: Cursor

elizabetdev dismissed pulpdrew’s stale review via 4a54426 March 20, 2026 19:12

vercel bot deployed to Preview March 20, 2026 19:15 View deployment

elizabetdev added the automerge label Mar 20, 2026

elizabetdev requested a review from pulpdrew March 20, 2026 19:17

Merge branch 'main' into feat/enhance-data-source-select

e6a3f76

pulpdrew approved these changes Mar 20, 2026

View reviewed changes

vercel bot deployed to Preview March 20, 2026 19:20 View deployment

kodiakhq bot merged commit 3d15b3d into main Mar 20, 2026
15 checks passed

kodiakhq bot deleted the feat/enhance-data-source-select branch March 20, 2026 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enhance data source select with context-aware icons and inline actions#1948

feat: Enhance data source select with context-aware icons and inline actions#1948
kodiakhq[bot] merged 8 commits intomainfrom
feat/enhance-data-source-select

elizabetdev commented Mar 20, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

pulpdrew left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

elizabetdev commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

changeset-bot bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

pulpdrew left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

elizabetdev commented Mar 20, 2026 •

edited

Loading

changeset-bot bot commented Mar 20, 2026 •

edited

Loading

vercel bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading