Skip to content

fix: require consent on account creation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kzoeps wants to merge 1 commit into from
Closed

fix: require consent on account creation #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/auth-service/src/routes/complete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ export function createCompleteRouter(
const isNewAccount = !did

const clientId = flow.clientId ?? ''
const needsConsent =
!isNewAccount && clientId && !ctx.db.hasClientLogin(email, clientId)
const needsConsent = clientId && !ctx.db.hasClientLogin(email, clientId)

if (needsConsent) {
// Step 5a: Redirect to consent screen, passing flow_id so consent can
Expand Down
1 change: 0 additions & 1 deletion packages/pds-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ async function main() {
const requestUri = req.query.request_uri as string
const email = ((req.query.email as string) || '').toLowerCase()
const approved = req.query.approved === '1'
const _isNewAccount = req.query.new_account === '1'
const ts = req.query.ts as string
const sig = req.query.sig as string

Expand Down
Loading