fix(daemon): lock entitlement cache file permissions#78
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b0c0992 to
30293e4
Compare
Motivation
entitlement.jsonusingtokio::fs::write, which on Unix can produce world-readable files depending on the process umask and risk local token disclosure.Description
tokio::fs::writewith a dedicated helperwrite_entitlement_cacheand call it fromstore_entitlement_responseto centralize cache writes.OpenOptionsExt::mode(0o600)(viaspawn_blocking) to enforce owner-only read/write permissions.tokio::fs::writeto preserve existing behavior.cloud_entitlement_cache_round_trips_and_deletes_tokento assert the cached file mode is0600on Unix.Testing
cloud_entitlement_cache_round_trips_and_deletes_tokenin thehypercolor-daemoncrate; the build/test run was started in the session but did not complete within the time window.0o600) on Unix as part of the existing test to prevent regressions.Codex Task