fix(gpu-interop): clean up pooled GL slots on constructor failure#76
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4b59a66 to
9aa082e
Compare
Motivation
LinuxGlFramebufferImporter::newfails partway through creating pooledImportedFrameSlots, which previously dropped partially-constructed slots without invoking GL cleanup and could exhaust GPU resources.Description
crates/hypercolor-linux-gpu-interop/src/linux.rsupdateLinuxGlFramebufferImporter::newto explicitly calldestroy_gl_resourceson all previously-created slots ifImportedFrameSlot::create(...)returns an error, then return the original error to avoid partial-construction leaks.Testing
cargo test -p hypercolor-linux-gpu-interop --no-default-features --lib --no-runand the test build completed successfully.Codex Task