Skip to content

fix(app): avoid logging daemon URLs with query tokens #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperb1iss merged 1 commit into from
May 19, 2026
Merged

fix(app): avoid logging daemon URLs with query tokens #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/hypercolor-app/src/daemon_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ impl DaemonClient {
.send(Message::Text(subscribe_msg.to_string().into()))
.await?;

info!("Connected to daemon WebSocket at {}", self.ws_url);
info!("Connected to daemon WebSocket");

loop {
tokio::select! {
Expand Down
4 changes: 2 additions & 2 deletions crates/hypercolor-app/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fn main() -> anyhow::Result<()> {
let daemon_url = std::env::var("HYPERCOLOR_URL")
.unwrap_or_else(|_| hypercolor_app::DEFAULT_DAEMON_URL.to_string());

tracing::info!(url = %daemon_url, "launching Hypercolor app shell");
tracing::info!("launching Hypercolor app shell");

tauri::Builder::default()
.manage(hypercolor_app::supervisor::SupervisorState::default())
Expand Down Expand Up @@ -59,7 +59,7 @@ fn main() -> anyhow::Result<()> {
.parse()
.expect("HYPERCOLOR_URL must be a valid URL");

tracing::info!(%url, "creating webview window");
tracing::info!(scheme = %url.scheme(), host = ?url.host_str(), port = ?url.port_or_known_default(), "creating webview window");

let window = WebviewWindowBuilder::new(app, "main", WebviewUrl::External(url.clone()))
.title("Hypercolor")
Expand Down
Loading