Remove local to global scroll resync above some threshold#438
Open
Remove local to global scroll resync above some threshold#438
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the accumulated localOffset threshold check from the dual-mode virtual scrolling implementation, allowing continuous local scrolling without forced resynchronization to global scroll mode after 500 rows. This change addresses issue #435, which identified that the previous behavior could theoretically make some rows inaccessible in datasets with more than 4 billion rows.
Changes:
- Removed the accumulated localOffset check from
canBeLocalScroll()function, keeping only the per-delta size check - Updated test descriptions and expectations to reflect the new behavior where local scrolling continues regardless of accumulated offset
- Simplified function signatures by removing the now-unused localOffset parameter from the scroll eligibility check
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/helpers/scroll.ts | Removed accumulated localOffset check from canBeLocalScroll(), allowing indefinite local scrolling when individual scroll deltas remain small |
| test/helpers/scroll.test.ts | Updated test descriptions and expectations to validate that local scrolling continues even when accumulated localOffset exceeds the threshold |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ead77c7 to
704f172
Compare
Contributor
Author
|
wdyt @platypii? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: we would switch to global scrolling after scrolling 500 rows locally.
After: we always stay in local scroll mode, when scrolling row by row.
Screencast.From.2026-02-23.14-45-35.mp4
fixes #435