-
-
Notifications
You must be signed in to change notification settings - Fork 13
[2.x] Remove experimental annotations from codebase #2313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed various @experimental comments and annotations from documentation, configuration, and source files to reflect stabilization of features and APIs. Updated documentation to indicate 'basic' rather than 'experimental' support for Blade front matter. No functional code changes were made.
ae856d7 to
3de5efd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2313 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2000 2000
===========================================
Files 197 197
Lines 5174 5174
===========================================
Hits 5174 5174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes experimental annotations from various components throughout the HydePHP codebase to reflect the stabilization of features and APIs for the v2 release. The changes focus on cleaning up documentation and comments rather than modifying functional code.
- Removed
@experimentalannotations from helper methods, classes, and configuration options - Updated documentation to describe Blade front matter support as 'basic' instead of 'experimental'
- Cleaned up configuration file comments to remove experimental labeling
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/testing/src/FluentTestingHelpers.php | Removed experimental annotations from dd() and formatArray() helper methods |
| packages/realtime-compiler/src/ConsoleOutput.php | Removed experimental annotation from printMessage() method |
| packages/realtime-compiler/src/Console/Commands/ServeCommand.php | Removed experimental warning from isPortAvailable() method |
| packages/framework/src/Support/Models/RouteKey.php | Removed experimental annotation from stripPrefixIfNeeded() method |
| packages/framework/src/Support/Internal/RouteListItem.php | Removed experimental comment about typeLabel macro |
| packages/framework/src/Framework/Features/Navigation/NavigationMenuGenerator.php | Removed experimental class-level annotation |
| packages/framework/src/Framework/Features/Navigation/NavigationGroup.php | Removed experimental annotation from normalizeGroupKey() method |
| packages/framework/src/Framework/Exceptions/ParseException.php | Removed experimental class-level annotation |
| packages/framework/src/Framework/Exceptions/InvalidConfigurationException.php | Removed experimental annotation from try() method |
| packages/framework/src/Framework/Concerns/RegistersFileLocations.php | Removed experimental comment about kebab-case class name support |
| packages/framework/src/Facades/Config.php | Simplified experimental comment for getNullableString() method |
| monorepo/gh-pages/gh-pages-config/config/hyde.php | Updated configuration comments to remove experimental labeling |
| monorepo/gh-pages/gh-pages-config-dev-docs/config/hyde.php | Updated configuration comments to remove experimental labeling |
| docs/getting-started/front-matter.md | Changed Blade front matter support description from 'experimental' to 'basic' |
| docs/getting-started/core-concepts.md | Changed Blade front matter support description from 'experimental' to 'basic' |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Removed various @experimental comments and annotations from documentation, configuration, and source files to reflect stabilization of features and APIs. Updated documentation to indicate 'basic' rather than 'experimental' support for Blade front matter. No functional code changes were made. This is because either these changes are now stable after being experimental for a while, or because we are committing to them for the v2 release.