Skip to content

Conversation

@emmadesilva
Copy link
Member

Abstract

Comparison

Before

PS H:\monorepo> npm run build

> build
> vite build

vite v5.4.10 building for production...
✓ 2 modules transformed.
Generated an empty chunk: "app".
_media/app.css  38.78 kB │ gzip: 7.51 kB
_media/app.js    0.00 kB │ gzip: 0.02 kB
✓ built in 1.09s

After

Without contents

PS H:\monorepo> npm run build

> build
> vite build

vite v5.4.10 building for production...
✓ 1 modules transformed.
_media/app.css  37.77 kB │ gzip: 7.27 kB
✓ built in 1.44s

With contents

PS H:\monorepo> npm run build

> build
> vite build

vite v5.4.10 building for production...
✓ 2 modules transformed.
_media/app.css  37.77 kB │ gzip: 7.27 kB
_media/app.js    0.02 kB │ gzip: 0.04 kB
✓ built in 986ms

@emmadesilva emmadesilva marked this pull request as ready for review November 16, 2024 11:31
@emmadesilva emmadesilva merged commit b418b52 into new-asset-system Nov 16, 2024
@emmadesilva emmadesilva deleted the only-compile-app-scripts-if-it-has-content branch November 16, 2024 11:31
@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c42d8fe) to head (64b33c5).
Report is 3 commits behind head on new-asset-system.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             new-asset-system     #2028   +/-   ##
====================================================
  Coverage              100.00%   100.00%           
  Complexity               1906      1906           
====================================================
  Files                     195       195           
  Lines                    5078      5078           
====================================================
  Hits                     5078      5078           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants