Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Nov 10, 2024

GitHub got glitched, so this PR was replaced by #2010

@emmadesilva emmadesilva mentioned this pull request Nov 10, 2024
17 tasks
@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e800ecf) to head (e6667aa).

Additional details and impacted files
@@                 Coverage Diff                  @@
##             new-asset-system     #2007   +/-   ##
====================================================
  Coverage              100.00%   100.00%           
  Complexity               1891      1891           
====================================================
  Files                     194       194           
  Lines                    5044      5044           
====================================================
  Hits                     5044      5044           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 10, 2024
@emmadesilva emmadesilva force-pushed the use-vite-instead-of-mix branch 5 times, most recently from d140756 to ff6c305 Compare November 11, 2024 08:57
@emmadesilva
Copy link
Member Author

emmadesilva commented Nov 11, 2024

Since run dev has a changed scope, we may want to remove this: (a merged --vite option may work better)

if ($this->option('run-dev')) {
    $this->runNodeCommand('npm run dev', 'Building frontend assets for development!');
}

And update this:

Then run npm run dev to compile the assets in development mode. For production builds, run npm run build.

@emmadesilva emmadesilva marked this pull request as ready for review November 11, 2024 09:03
@emmadesilva emmadesilva force-pushed the use-vite-instead-of-mix branch from 3c83a87 to e6667aa Compare November 11, 2024 09:07
@emmadesilva emmadesilva merged commit e800ecf into new-asset-system Nov 11, 2024
@emmadesilva emmadesilva deleted the use-vite-instead-of-mix branch November 11, 2024 09:10
@github-actions github-actions bot removed the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 11, 2024
@emmadesilva emmadesilva restored the use-vite-instead-of-mix branch November 11, 2024 09:12
@emmadesilva
Copy link
Member Author

GitHub got glitched, so this PR was replaced by #2010

@emmadesilva emmadesilva changed the title [2.x] Replace Laravel Mix with Vite Internal: GitHub pull request issue Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants