Refactor: migrate 5 L2 scene tests to SceneTestCase#518
Open
hw-native-sys-bot wants to merge 1 commit intohw-native-sys:mainfrom
Open
Refactor: migrate 5 L2 scene tests to SceneTestCase#518hw-native-sys-bot wants to merge 1 commit intohw-native-sys:mainfrom
hw-native-sys-bot wants to merge 1 commit intohw-native-sys:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the Paged Attention implementation from a small-scale float16 prototype to a production-scale bfloat16 version. Key changes include updating AIC and AIV kernels to support dynamic tile configurations via template dispatch, modifying the orchestration logic to handle larger scales, and introducing a comprehensive suite of tests for various runtimes (aicpu_build_graph, host_build_graph, and tensormap_and_ringbuffer). Additionally, several legacy configuration and golden test files were removed, and the project configuration was updated to include the golden directory in the Python path. I have no feedback to provide as there were no review comments to assess.
0abece2 to
6d658d9
Compare
…TestCase Move 5 old-style (golden.py + kernel_config.py) tests to SceneTestCase: - scalar_data_test: multi-output (D.OUT x2), kernel_noop (empty signature) - alternating_matmul_add: int64 scalars, AIC matmul kernel, RTOL=1e-3 - paged_attention_ringbuffer: RUNTIME_ENV, INOUT tensors, bfloat16 - aicpu_build_graph/paged_attention: aicpu_build_graph runtime, hub kernels - host_build_graph/paged_attention: host_build_graph runtime (st version replaces example's small-scale version) Also add golden/ to pytest pythonpath for paged_attention_golden imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6d658d9 to
00fc6a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/st/toexamples/, delete old golden.py + kernel_config.pygolden/to pytest pythonpath for shared paged_attention_golden importsTests migrated (each verifies a new framework feature):
D.OUTx2), empty kernel signature ([])int64scalars, AIC (CUBE) matmul kernel,RTOL=1e-3RUNTIME_ENV,D.INOUTtensors, bfloat16aicpu_build_graphruntime, hub kernelshost_build_graphruntime (st version replaces example's small-scale version)Test plan
pytest tests/ut -x -q— 149 passedpytest --collect-only— 5 new tests collected without errors🤖 Generated with Claude Code