Add Qwen3 out-window compile flag#422
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe decode forward path CLI gains a new ChangesOut-window externalization configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a new command-line argument --enable-out-window-externalization and passes it to the compiler configuration in models/qwen3/14b/decode_fwd.py. The feedback suggests adding a help description to the new argument for better usability, and conditionally passing the compile_cfg dictionary only when the flag is enabled to maintain backward compatibility with older PyPTO versions.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@models/qwen3/14b/decode_fwd.py`:
- Around line 579-581: The compile_cfg dict in decode_fwd.py unconditionally
includes enable_out_window_externalization which can forward an unsupported
kwarg into fn._compile via compile_kwargs and cause a TypeError; change the code
that builds compile_cfg so it only inserts the enable_out_window_externalization
key when the CLI flag/variable is truthy (or explicitly set) rather than always
adding it — i.e., check the variable (enable_out_window_externalization) before
adding to compile_cfg, or build compile_cfg conditionally, so fn._compile is
only called with supported keys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fb744d05-310e-4188-bb84-c2a934a37c77
📒 Files selected for processing (1)
models/qwen3/14b/decode_fwd.py
- Accept simulator platforms in decode_fwd CLI for CI runs - Only forward enable_out_window_externalization when requested - Add a static CLI smoke test for the PR regression
Keep the script default small enough for CI simulator runs while preserving the full-model default in build_tensor_specs for explicit callers.
Summary
--enable-out-window-externalizationto the Qwen3 14Bdecode_fwd.pyrunner.compile_cfgasenable_out_window_externalization, keeping the default path unchanged when the flag is absent.Related Issues