[PTOAS] finalize pipe init nosplit semantics#469
Open
TaoTao-real wants to merge 3 commits intohw-native-sys:codex/pipe-init-nosplitfrom
Open
[PTOAS] finalize pipe init nosplit semantics#469TaoTao-real wants to merge 3 commits intohw-native-sys:codex/pipe-init-nosplitfrom
TaoTao-real wants to merge 3 commits intohw-native-sys:codex/pipe-init-nosplitfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nosplitsupport foraic/aiv_initialize_pipenosplitfrom downstream split usage for backward compatibilityTPipetemplate argument order with the updatedpto-isalayoutMotivation
ResolveReservedBufferstest/samples/TPushTPop/test3/kernel.ptothat omits init-levelnosplitnosplitexplicitly and fail early when user intent conflicts with downstreamsplitDesign
nosplitand forward it duringpto-lower-frontend-pipe-opspto-infer-validate-pipe-initmodule pass runs before memory planning to:nosplit=true/falsefromtpush/tpop/tfreesplit usage when missingsplit=0mixed withsplit=1/2on the same logical pipenosplitmismatches and peer-pipe conflictsnosplitacross peer init pairspto-resolve-reserved-buffersis narrowed back to flag-base alignment + reserve/import address materializationTPipe<flag, dir, slotSize, slotNum, nosplit, localSlotNum>TPipe<flag, dir, slotSize, slotNum, nosplit>Testing
ninja -C build ptoastest/basic/tpush_tpop_emitc.ptotest/basic/tpush_tpop_frontend_lowering_a3.ptotest/basic/tpush_tpop_frontend_lowering_a5.ptotest/basic/tpush_tpop_frontend_nosplit_a5.ptotest/basic/tpush_tpop_frontend_mixed_split_a5.ptotest/basic/tpush_tpop_frontend_nosplit_conflict_a5.ptotest/basic/resolve_reserved_buffers_reject_incomplete_peer_group_a5.ptotest/basic/resolve_reserved_buffers_reject_non_peer_init_a5.ptoptoas --pto-arch=a5 --enable-insert-sync test/samples/TPushTPop/test3/kernel.ptoTPipe<0, Direction::DIR_BOTH, 1024, 4, true>plus matchingTPUSH/TPOP/TFREEfor the round-trip pathRisk / Rollback
codex/pipe-init-nosplit), so merge order matters