Skip to content

Conversation

@zucchini-nlp
Copy link
Member

What does this PR do?

Check docstring currently doesn't check modular files. So if a class is defined in modular without any "copying" and has a bad docstring, we do not check it. Instead we check the auto-generated code, which sometimes is annoying

This is a draft made by a code agent and edited by me. It relies on AST to parse the docstring. I think we can entirely switch to AST so I will try to clean up the check_docstring file. Opening a draft for now to make sure we're not doing duplicate work

fyi @ydshieh

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: afmoe, aria, d_fine, glm4v

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants