[WIP] Check docstring runs on modular files #43587
Open
+336
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check docstring currently doesn't check modular files. So if a class is defined in modular without any "copying" and has a bad docstring, we do not check it. Instead we check the auto-generated code, which sometimes is annoying
This is a draft made by a code agent and edited by me. It relies on AST to parse the docstring. I think we can entirely switch to AST so I will try to clean up the
check_docstringfile. Opening a draft for now to make sure we're not doing duplicate workfyi @ydshieh