Skip to content

[Sam] Fixup training flags#43567

Merged
vasqu merged 4 commits intomainfrom
fix-training-flags
Feb 2, 2026
Merged

[Sam] Fixup training flags#43567
vasqu merged 4 commits intomainfrom
fix-training-flags

Conversation

@vasqu
Copy link
Copy Markdown
Contributor

@vasqu vasqu commented Jan 28, 2026

Kind of a follow up to #43556 which fixed a bunch of wrong inheritance with gradient ckpting. Just dummy exchanged the proper flags and I didn't have to skip a lot of these tests

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: edgetam, sam, sam2, sam3, sam3_tracker, sam_hq

@vasqu vasqu marked this pull request as ready for review January 29, 2026 14:01
@vasqu vasqu requested a review from yonigozlan January 29, 2026 14:01
Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to less tests skipped :)

@vasqu vasqu merged commit aeb728a into main Feb 2, 2026
21 checks passed
@vasqu vasqu deleted the fix-training-flags branch February 2, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants