Skip to content

Conversation

@Sai-Suraj-27
Copy link
Contributor

What does this PR do?

Fixes failing Owlv2ImageProcessingTest

image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@yonigozlan @Rocketknight1

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: owlv2

@Sai-Suraj-27 Sai-Suraj-27 force-pushed the fix_owlv2_img_processor_test branch from a1a1901 to bb1f66e Compare December 8, 2025 18:56
@Rocketknight1
Copy link
Member

run-slow: owlv2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

This comment contains run-slow, running the specified jobs:

models: ["models/owlv2"]
quantizations: []

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM. Thank you for the PR!

@Rocketknight1 Rocketknight1 merged commit ec37fc8 into huggingface:main Dec 9, 2025
17 checks passed
@Sai-Suraj-27
Copy link
Contributor Author

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

Hey, @Rocketknight1. Any idea, on what basis, this comment is returning no failing test? Because when I see the Workflow Run ⚙️. 1 test is failing. This test was failing before also, It's not related to the changes in the PR, but still I think It should ideally report that failing test right? as it's from the same model.
I am guessing, some issue here Post results as PR comment, will try to check.

@Rocketknight1
Copy link
Member

When a test is failing already, we ignore it because we really just want to ensure that the PR isn't making things any worse 😅

@Sai-Suraj-27
Copy link
Contributor Author

When a test is failing already, we ignore it because we really just want to ensure that the PR isn't making things any worse 😅

Got, it. Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants