Add --load-tasks-multilingual and fix --custom-tasks for inspect backend#1199
Open
dzautner wants to merge 1 commit intohuggingface:mainfrom
Open
Add --load-tasks-multilingual and fix --custom-tasks for inspect backend#1199dzautner wants to merge 1 commit intohuggingface:mainfrom
dzautner wants to merge 1 commit intohuggingface:mainfrom
Conversation
… backend The inspect backend hardcoded load_multilingual=False and custom_tasks=None, making it impossible to use multilingual tasks or custom task files. Wire both CLI parameters through to the Registry, consistent with all other backends (vllm, accelerate, sglang, endpoint, etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The inspect backend (
lighteval eval) hardcodescustom_tasks=Noneandload_multilingual=Falsewhen constructing theRegistry, making it impossible to use multilingual or custom tasks. All other backends (vllm, accelerate, sglang, endpoint) properly accept and pass through both parameters.This PR:
--load-tasks-multilingualCLI flag to the inspect backend, reusing the sharedload_tasks_multilingualarg fromcli_args.py(same pattern as all other backends)custom_tasksbeing hardcoded toNone— the parameter already exists in the function signature but was never forwarded toRegistryChanges (3 lines in
main_inspect.py)load_tasks_multilingualparameter to theeval()functioncustom_tasksandload_tasks_multilingualtoRegistry()instead of hardcoded valuesUsage
Test plan
--load-tasks-multilingualflag appears in CLI helpmultilingual/tasks/)maime25:fi(30 samples) completed successfully on AMD MI325X cluster using vLLM backend through inspect-ai