upload: fix benchmark deletion filter to match upload filter#543
Open
Dev-X25874 wants to merge 1 commit into
Open
upload: fix benchmark deletion filter to match upload filter#543Dev-X25874 wants to merge 1 commit into
Dev-X25874 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #
What does this PR do?
The deletion predicate in
collect_benchmark_commit_opswas missing&& n.ends_with(".py"), causing non-.pyfiles underbenchmarks/to be incorrectly deleted on existing branches.Motivation
The upload pass only adds
benchmark*.pyfiles. The deletion pass should match the same filter. The existing comment even stated "only delete benchmark*.py" but the predicate didn't enforce it.Changes
&& n.ends_with(".py")to the deletion predicate incollect_benchmark_commit_opsTesting
Checklist