Skip to content

fix: update nix warns to throws #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drbh merged 1 commit into from
May 13, 2026
Merged

fix: update nix warns to throws #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
torchVersions';
in
builtins.toJSON buildVariants;
genFlakeOutputs = builtins.warn ''
genFlakeOutputs = builtins.throw ''
`genFlakeOutputs` was renamed to `genKernelFlakeOutputs` and will be removed
in kernel-builder 0.14.
'' genKernelFlakeOutputs;
Expand Down
4 changes: 2 additions & 2 deletions nix-builder/lib/gen-flake-outputs.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ let
'';
flakeRev =
if self != null then
self.shortRev or self.dirtyShortRev or (builtins.warn ''
self.shortRev or self.dirtyShortRev or (builtins.throw ''
Kernel is not in a git repository, this will create a non-reproducible build.
This will not be supported in the future.
'' self.lastModifiedDate)
else if rev != null then
builtins.warn "`rev` argument of `genKernelFlakeOutputs` is deprecated, pass `self` as follows:\n\n${supportedFormat}" rev
builtins.throw "`rev` argument of `genKernelFlakeOutputs` is deprecated, pass `self` as follows:\n\n${supportedFormat}" rev
else
throw "Flake's `self` must be passed to `genKernelFlakeOutputs` as follows:\n\n${supportedFormat}";

Expand Down
Loading