Backport kernels changes for FA4 support#383
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| module_name = python_package.replace("-", "_") | ||
| pkg_name = python_package.get("pkg") | ||
| # Assertion because this should not happen and is a bug. | ||
| assert ( | ||
| pkg_name is not None | ||
| ), f"Invalid dependency data for `{dependency}`: missing `pkg` field." |
There was a problem hiding this comment.
Yes, this is what confused me yesterday during debugging
There was a problem hiding this comment.
But this one shouldn't occur, unless the JSON file is corrupt somehow.
| "general": { | ||
| "einops": { | ||
| "nix": ["einops"], | ||
| "python": ["einops"] |
There was a problem hiding this comment.
Do we generate this manually? Would it be prudent to generate it automatically if it makes sense?
There was a problem hiding this comment.
Yes, this is hand-written. I don't know an easy way to do it automatically, also not sure if it is needed, I don't think we should go beyond a handful of dependencies. Otherwise we are back to Python wheels.
4 participants
No description provided.