Open
Conversation
534af0b to
368adad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a WIP to add the init command to the kernel-builder rust cli. This branch mainly ports the init command from the python cli, with some improvements to the interface and updates to the templateThis PR adds an the
initanduploadcommand to the rust kernel-builder cli similar to implementation in the current python cli. It also adds abuildcommand that is a facade for thenix runso devs can interact with a single tool for the full creation lifecycle of a kernel.Mainly it aims to have better defaults to make the commands easier to use
initcommand only requires the name of the kernels (folder) and the owner is pulled via awhoamirequest if the user is already logged into hfinitcommand creates a new dir if a name is specified, if called within a dir, the cli will use the dir name as the kernel nameuploadcommand does not require a repo id if the id can be read from the builduploadcommand does not require a path to the build folder and will default to looking for thebuilddir if no explicit path is specifiedexample usage
init from inside of a existing dir
init from outside of a dir
build
upload