Fix missing gradient_checkpointing init in ZImageControlNetModel#13267
Open
yunjoochoi wants to merge 2 commits intohuggingface:mainfrom
Open
Fix missing gradient_checkpointing init in ZImageControlNetModel#13267yunjoochoi wants to merge 2 commits intohuggingface:mainfrom
yunjoochoi wants to merge 2 commits intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
One-line fix — missing self.gradient_checkpointing = False init, consistent with all other ControlNet implementations
ZImageControlNetModelsets_supports_gradient_checkpointing = Trueand referencesself.gradient_checkpointingin itsforward()method, but never initializesself.gradient_checkpointing = Falsein__init__().This causes
enable_gradient_checkpointing()to raise:ValueError: The module ZImageControlNetModel does not support gradient checkpointing.
Please make sure to use a module that supports gradient checkpointing by creating
a boolean attribute gradient_checkpointing.